Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum validator commission rate param #3831

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Minimum validator commission rate param #3831

wants to merge 3 commits into from

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Sep 20, 2024 •
edited
Loading

Describe your changes

Adds a PoS param to enforce a minimum allowed validator commission rate.

Also includes logic in init_chain to set a validator's commission rate to the minimum if the one provided in the toml file is below.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@brentstone brentstone marked this pull request as ready for review September 20, 2024 01:12
@brentstone brentstone added this to the v0.44.0 milestone Sep 21, 2024
@tzemanovic tzemanovic self-assigned this Sep 23, 2024
@brentstone brentstone force-pushed the brent/min-commission-param branch 2 times, most recently from 3b241d6 to 68fbefe Compare September 24, 2024 00:47
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.88889% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.07%. Comparing base (760462b) to head (637a0a0).

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 41.66% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3831      +/-   ##
==========================================
+ Coverage   73.01%   73.07%   +0.05%     
==========================================
  Files         340      340              
  Lines      104750   104791      +41     
==========================================
+ Hits        76488    76571      +83     
+ Misses      28262    28220      -42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone marked this pull request as draft September 24, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tzemanovic tzemanovic

Labels
breaking:genesis breaking: protocol PoS
Projects
None yet
Milestone
Future breaking upgrade
Development

Successfully merging this pull request may close these issues.
2 participants
@brentstone @tzemanovic